fix(volo-http): avoid IntoResponse impl conflict with Infallible - #662
Open
Joshuahoky wants to merge 2 commits into
Open
fix(volo-http): avoid IntoResponse impl conflict with Infallible#662Joshuahoky wants to merge 2 commits into
Joshuahoky wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
==========================================
- Coverage 46.93% 46.93% -0.01%
==========================================
Files 163 163
Lines 20454 20452 -2
==========================================
- Hits 9600 9599 -1
+ Misses 10854 10853 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Joshuahoky
force-pushed
the
fix/infallible
branch
from
August 11, 2026 12:57
d152c18 to
c36f16a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
See #652
Solution
Added an opt in trait
TryIntoResponseBodyso that if the patch does happen, the compiler will not detect two different traits implementations for!. However this is a breaking change for existing downstream users using their own custom body types. Their code will fail to compile until they add the followingimpl TryIntoResponseBody for MyBody {}