Skip to content

fix(volo-http): avoid IntoResponse impl conflict with Infallible - #662

Open
Joshuahoky wants to merge 2 commits into
mainfrom
fix/infallible
Open

fix(volo-http): avoid IntoResponse impl conflict with Infallible#662
Joshuahoky wants to merge 2 commits into
mainfrom
fix/infallible

Conversation

@Joshuahoky

@Joshuahoky Joshuahoky commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Motivation

See #652

Solution

Added an opt in trait TryIntoResponseBody so that if the patch does happen, the compiler will not detect two different traits implementations for !. However this is a breaking change for existing downstream users using their own custom body types. Their code will fail to compile until they add the following
impl TryIntoResponseBody for MyBody {}

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.93%. Comparing base (43dd124) to head (c36f16a).

Files with missing lines Patch % Lines
volo-build/src/thrift_backend.rs 0.00% 21 Missing ⚠️
volo-build/src/grpc_backend.rs 0.00% 16 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
- Coverage   46.93%   46.93%   -0.01%     
==========================================
  Files         163      163              
  Lines       20454    20452       -2     
==========================================
- Hits         9600     9599       -1     
+ Misses      10854    10853       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant