Skip to content

consider never using sandbox.preserve_env #1718

Description

@prandla

Currently, cms passes all env variables from the host into compiler and checker invocations. This seems quite unnecessary to me, and AFAIK is not mentioned in the manual. It is relatively common to pass api tokens or whatnot in environment variables, so server admins may unwittingly expose sensitive information in it (even though CMS itself doesn't use env vars for this).

All language compilers should work fine without any extra env vars (in #1545 i disabled preserve_env and only had to add PATH manually). I can't think of any reason to pass extra env vars to checkers (if you want to give it extra information, you can just hardcode it into the checker binary or something). Hence I propose disabling preserve_env for both compilation and checker runs.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions