Skip to content

docs: fix inaccurate live migration bullet in CR reservations #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilippMatthes merged 1 commit into from
Aug 17, 2026
+1 −1
Merged

docs: fix inaccurate live migration bullet in CR reservations #1138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/reservations/committed-resource-reservations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ The `spec_only_unblocked` term exists because an InFlightReservation on the same
**Corner cases worth noting:**
- Confirmed VMs exceed reservation size (e.g. after resize): clamp `remaining` to 0, never negative
- Spec-only VM larger than remaining slot: block `spec_only_unblocked` — those resources will land when the VM starts
- Live migration within a reservation: handled implicitly by `hv.Status.Allocation`, which libvirt reports on both source and target during migration; no special logic needed
- Live migration within a reservation: when a confirmed VM disappears from its expected host, the controller scans all hypervisors. If the VM is the sole allocation and the new host has capacity, the reservation follows the VM; otherwise the VM is removed from the reservation.

### InFlightReservation

Expand Down