fix(scene): preserve prefab root on delete - #896
Open
bofeng-song wants to merge 1 commit into
Open
Conversation
bofeng-song
requested review from
doommm and
knoxHuang
and removed request for
knoxHuang
August 31, 2026 03:15
bofeng-song
force-pushed
the
fix/prefab-root-delete
branch
from
August 31, 2026 06:06
dc648cc to
614de19
Compare
bofeng-song
force-pushed
the
fix/prefab-root-delete
branch
from
August 31, 2026 06:11
614de19 to
506ab86
Compare
doommm
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Deleting a select-all hierarchy in prefab editing mode could include the prefab root. CLI removed that root together with the selected nodes, and the editor later displayed anonymous
Empty Nodeentries instead of retaining the prefab root and its name.Creator keeps the opened prefab asset root in this case.
Cause
NodeService.delete()did not distinguish the current prefab editor root from regular nodes. A delete request targeting the root therefore removed the complete prefab hierarchy.Fix
Validation
npx tsc --noEmit --pretty falsepasses.glnative module was built for a different Node ABI.