fix(prefab): preserve structural edits through redo - #897
Open
bofeng-song wants to merge 3 commits into
Open
Conversation
bofeng-song
force-pushed
the
fix/prefab-edit-structure-undo
branch
from
August 31, 2026 06:36
005e40c to
6b0401e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After adding or removing nodes in prefab editing mode and saving, Undo could remove the structural change but Redo did not reliably restore it in the prefab asset or its scene instances.
Cause
Structural edits were recorded as individual node commands, while saving the prefab wrote the complete prefab asset separately. The asset reload could therefore replace the replayed node state with serialized content that did not match the Undo/Redo command.
Fix
Validation
npx tsc --noEmit --pretty falsenpx jest src/core/scene/test/editor-close-options.test.ts src/core/scene/test/editor-save-as.test.ts --runInBand