Repository navigation
Add hard-coded password detection rule for Kotlin #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
claudiacodacy
wants to merge
1
commit into
codacy:main
Choose a base branch
from
claudiacodacy:add-kotlin-hardcoded-password-rule
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -85,6 +85,29 @@ rules: | |||||
| - javascript | ||||||
| impact: HIGH | ||||||
| confidence: MEDIUM | ||||||
| - id: codacy.kotlin.security.hard-coded-password | ||||||
| severity: ERROR | ||||||
| languages: | ||||||
| - kotlin | ||||||
| patterns: | ||||||
| - pattern-either: | ||||||
| - pattern: 'val $PASSWORD = "$VALUE"' | ||||||
| - pattern: 'var $PASSWORD = "$VALUE"' | ||||||
| - pattern: 'val $PASSWORD: String = "$VALUE"' | ||||||
| - pattern: 'var $PASSWORD: String = "$VALUE"' | ||||||
| - metavariable-regex: | ||||||
| metavariable: "$PASSWORD" | ||||||
| regex: "(?i).*(password|motdepasse|heslo|adgangskode|wachtwoord|salasana|passwort|passord|senha|geslo|clave|losenord|clave|parola|secret|pwd|(api|secret|private|access|aws|ssh|auth|session|encryption|decryption|gcp)[_-]?key).*" | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ⚪ LOW RISK Nitpick: The regular expression contains redundant entries. Specifically, the keyword 'clave' is duplicated, and 'secret' is potentially redundant within the current structure.
Suggested change
|
||||||
| message: Hardcoded passwords are a security risk. They can be easily found by attackers and used to gain unauthorized access to the system. | ||||||
| metadata: | ||||||
| owasp: | ||||||
| - A3:2017 Sensitive Data Exposure | ||||||
| description: Hardcoded passwords are a security risk. | ||||||
| category: security | ||||||
| technology: | ||||||
| - kotlin | ||||||
| impact: HIGH | ||||||
| confidence: MEDIUM | ||||||
| - id: codacy.generic.plsql.empty-strings | ||||||
| severity: WARNING | ||||||
| languages: | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <module name="root"> | ||
| <module name="codacy.kotlin.security.hard-coded-password" /> | ||
| </module> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <?xml version="1.0" encoding="utf-8" ?> | ||
| <checkstyle version="1.5"> | ||
| <file name="Program.kt"> | ||
| <error source="codacy.kotlin.security.hard-coded-password" line="3" message="Hardcoded passwords are a security risk." severity="error" /> | ||
| <error source="codacy.kotlin.security.hard-coded-password" line="4" message="Hardcoded passwords are a security risk." severity="error" /> | ||
| <error source="codacy.kotlin.security.hard-coded-password" line="5" message="Hardcoded passwords are a security risk." severity="error" /> | ||
| </file> | ||
| </checkstyle> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| class Program { | ||
| fun main() { | ||
| val password = "password" // Issue: Hardcoded password | ||
| val apiKey = "api_key" // Issue: Hardcoded API key | ||
| val apiSecret: String = "api_secret" // Issue: Hardcoded API secret | ||
|
|
||
| println("This is a security risk: $password") | ||
| println("This is a security risk: $apiKey") | ||
| println("This is a security risk: $apiSecret") | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 MEDIUM RISK
Suggestion: The current patterns do not detect secrets assigned using
const valor those stored in triple-quoted string literals ("""..."""), both of which are common in Kotlin projects. It is recommended to update the rule to include these patterns for more robust detection.