fix(security): 2 improvements across 2 files#2336
Open
tomaioo wants to merge 2 commits intocodalab:developfrom
Open
fix(security): 2 improvements across 2 files#2336tomaioo wants to merge 2 commits intocodalab:developfrom
tomaioo wants to merge 2 commits intocodalab:developfrom
Conversation
- Security: TLS certificate verification disabled for Celery broker connection - Security: Path traversal in backup upload command allows arbitrary file read/delete Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: TLS certificate verification disabled for Celery broker connection - Security: Path traversal in backup upload command allows arbitrary file read/delete Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
High| File:compute_worker/celery_config.py:L6The Celery SSL configuration explicitly sets
cert_reqstossl.CERT_NONE, which disables server certificate validation. This allows man-in-the-middle interception of broker traffic (task payloads, credentials, and control messages) when SSL is enabled.Solution
Require certificate validation by setting
cert_reqstossl.CERT_REQUIRED, and provide a trusted CA bundle (ca_certs). Optionally configure client cert/key for mTLS. Example:broker_use_ssl = {'cert_reqs': ssl.CERT_REQUIRED, 'ca_certs': '/path/to/ca.pem'}.Changes
compute_worker/celery_config.py(modified)src/apps/commands/management/commands/upload_backup.py(modified)