Deny anonymous access to /api/submissions/ list and retrieve - #2536
Merged
Merged
Conversation
Collaborator
Author
Collaborator
|
Seems like either MinIO, in their infinite wisdom, decided to delete the image : https://hub.docker.com/r/minio/mc Small update, they also removed the MinIO images, seems like it's a deliberate act and not a bug. I made a PR to switch registry for those images #2537 |
Member
|
I'll merge the CircleCI fix and rebase this PR. From what I see, in addition to the data leakage problem, this PR also fixes possible unauthentificated state changes on Let's include it in the 1.32 release as requested by Chris. |
Anonymous GETs returned full submission records (filenames, status details, fact sheet answers) for any finished leaderboard submission, ignoring is_public. Now returns an empty queryset instead; public leaderboard data is already served by get_leaderboard in PhaseViewSet
Didayolo
force-pushed
the
leaderboard_annnymization
branch
from
September 14, 2026 13:48
b16c2f2 to
29e4362
Compare
Didayolo
approved these changes
Sep 14, 2026
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Anonymous GETs returned full submission records (filenames, status details, fact sheet answers) for any finished leaderboard submission, ignoring is_public. Now returns an empty queryset instead; public leaderboard data is already served by get_leaderboard in PhaseViewSet
Issues this PR resolves
NOTE
This PR reverts part of #1982
A checklist for hand testing
Checklist