Repository navigation
App title and favicon; unblock Dependabot updates - #15
Merged
Merged
Conversation
The browser tab read "frontend" (the Vite template default) and the favicon was Vite's logo. Title the page "Lead Management", replace the favicon with a simple funnel mark in the app's blue (#2563eb), and add an apple-touch-icon, theme-color and description. Remove the unused template leftover public/icons.svg. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018oMHDqDASywmwc7ncmxtCY
…Config
The paginated fake in LeadListPage.test.tsx declared its config parameter
as { params?: Record<string, number> }, narrower than axios's own
signature. Newer axios (1.20, in Dependabot's frontend group) types
params as unknown, so tsc -b rejected the mock and the Frontend check
failed on that PR. Accept AxiosRequestConfig and narrow params inside.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018oMHDqDASywmwc7ncmxtCY
- TypeScript 7 is the native (Go) compiler without the JS compiler API;
openapi-typescript 7.13 crashes under it ("Cannot read properties of
undefined (reading 'createKeywordTypeNode')"), which broke type
generation and the Frontend check on Dependabot's TypeScript 7 PR
- @types/node should follow the Node version the app runs on (22 in CI
and the Docker image), not the newest Node major
Minor and patch updates for both still come through.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018oMHDqDASywmwc7ncmxtCY
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Browser tab
The tab read "frontend" (the Vite template default) and the favicon was Vite's logo.
#2563eb).apple-touch-icon,theme-colorand a meta description.public/icons.svg.Unblocking Dependabot
LeadListPage.test.tsxtyped itsconfigparameter more narrowly than axios does. With axios 1.20, from Dependabot's frontend group (chore(frontend): bump the frontend group in /frontend with 19 updates #9),tsc -brejected it and the Frontend check failed. It now acceptsAxiosRequestConfig. I verified it against chore(frontend): bump the frontend group in /frontend with 19 updates #9'spackage.jsonand lockfile: tsc, lint, 74 tests and build all pass, and the old test still fails there.dependabot.yml):openapi-typescriptneeds. Type generation crashes (Cannot read properties of undefined (reading 'createKeywordTypeNode')), which is why chore(frontend): bump typescript from 6.0.3 to 7.0.2 in /frontend #11 fails.@types/nodemajors. These should match the Node version the app runs on (22), not the newest Node release.Testing
Frontend: 74 passed, and lint and build are clean. The Dependabot compatibility check is described above.
🤖 Generated with Claude Code
https://claude.ai/code/session_018oMHDqDASywmwc7ncmxtCY
Generated by Claude Code