Skip to content

Skip features that fail to load instead of crashing #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeto wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip features that fail to load instead of crashing #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Features/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@
import inspect

for loader, name, is_pkg in pkgutil.walk_packages(__path__):
module = loader.find_module(name).load_module(name)
try:
module = loader.find_module(name).load_module(name)
except Exception as e:
print("Skipping feature module {}: {}".format(name, e))
continue

for name, value in inspect.getmembers(module):
if name.endswith('Feature'):
Expand Down
6 changes: 5 additions & 1 deletion main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@
def loadFeatures():
classes = inspect.getmembers(sys.modules["Features"], inspect.isclass)
for featureName, featureClass in classes:
feature = featureClass();
try:
feature = featureClass()
except Exception as e:
print("Skipping feature {}: {}".format(featureName, e))
continue
for cmd in feature.cmdpairs:
commands[cmd] = feature.cmdpairs[cmd]

Expand Down