heartbeat status update#217
Open
raphael-goetz wants to merge 2 commits intomainfrom
Open
Conversation
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/draco/-/pipelines/2486059295 Status: Passed Job summariesdocs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/14127384713/artifacts/out/index.html |
Contributor
There was a problem hiding this comment.
Pull request overview
Implements periodic “heartbeat” updates for Draco runtime status (per #213) so Aquila/Sagittarius can observe liveness while an adapter is running, rather than relying on a one-time status change.
Changes:
- Add a configurable heartbeat interval (
ADAPTER_STATUS_UPDATE_INTERVAL_SECONDS, default 30s) to periodically update runtime status while running. - Spawn/abort a background Tokio task in the server runner to send periodic
Runningupdates. - Adjust runtime status update logging to be more concise.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/base/src/runner.rs | Wrap runtime status service in Arc and add a spawned heartbeat task with configurable interval and shutdown abort/await. |
| crates/base/src/config.rs | Add adapter_status_update_interval_seconds config sourced from env with a default value. |
| crates/base/src/client/mod.rs | Tweak runtime status update log messages and success/failure logging behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #213