Add latest PHP 8 version support#47
Open
kapilpandya22 wants to merge 3 commits intocode4business:masterfrom
Open
Add latest PHP 8 version support#47kapilpandya22 wants to merge 3 commits intocode4business:masterfrom
kapilpandya22 wants to merge 3 commits intocode4business:masterfrom
Conversation
Added latest PHP 8 versions to make this module compatible with magento 2.4.6 => version.
Replace all loose null comparisons (==, !=) with strict (===, !==), replace == false/== true patterns with negation operators, add missing type hint and return type to updateExtensionAttributes, and fix unsafe count() on potentially non-Countable value in RemoveGiftItems. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@domeglic , it would be wonderful, if you could check this PR shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added latest PHP 8 version support to make this module compatible with latest magento 2 versions.