Repository navigation
Remove stale ignored_columns entries from Member - #3021
Merged
olleolleolle merged 1 commit intoOct 13, 2026
Merged
Conversation
mroderick
marked this pull request as ready for review
October 13, 2026 08:28
olleolleolle
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #3016.
Memberstill listed two columns inignored_columns, and both are long gone:can_log_in— dropped ina2e7de00(2026-08-05)unsubscribed— dropped in69347342(2026-10-12, Remove unused unsubscribed column from members #3007)ignored_columnsbelongs to live columns only, so theself.ignored_columns += %w[can_log_in unsubscribed]line goes entirely.Changes
ignored_columnsentry on the model, so nothing remains of the list).Acceptance
Member.ignored_columnsis[].Member.all.to_sqlnames no stale columns.make test(1728 examples, 0 failures).rubocop app/models/member.rbclean.Review notes
ignored_columnsentries are tolerated by Rails, so this only removes dead configuration.