Skip to content

Remove stale ignored_columns entries from Member - #3021

Merged
olleolleolle merged 1 commit into
codebar:masterfrom
mroderick:chore/member-stale-ignored-columns
Oct 13, 2026
Merged

olleolleolle merged 1 commit into
codebar:masterfrom
mroderick:chore/member-stale-ignored-columns

Conversation

@mroderick

Copy link
Copy Markdown
Collaborator

Problem

Closes #3016.

Member still listed two columns in ignored_columns, and both are long gone:

ignored_columns belongs to live columns only, so the self.ignored_columns += %w[can_log_in unsubscribed] line goes entirely.

Changes

  • Remove the line (the only ignored_columns entry on the model, so nothing remains of the list).

Acceptance

  • Member.ignored_columns is [].
  • Member.all.to_sql names no stale columns.
  • Full suite passes: make test (1728 examples, 0 failures).
  • rubocop app/models/member.rb clean.
Review notes
  • Single-line, single-file diff. No schema change, no deploy risk: stale ignored_columns entries are tolerated by Rails, so this only removes dead configuration.

can_log_in was dropped in a2e7de0 and unsubscribed in 6934734,
but the ignored_columns list still referenced both. The list
belongs to live columns only, so the line goes entirely.
@mroderick
mroderick marked this pull request as ready for review October 13, 2026 08:28
@olleolleolle
olleolleolle merged commit 1ee181f into codebar:master Oct 13, 2026
11 checks passed
@mroderick
mroderick deleted the chore/member-stale-ignored-columns branch October 13, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove stale ignored_columns entries from Member

2 participants