Repository navigation
Drop the dead meetings.invites_sent column - #3023
Merged
mroderick merged 3 commits intoOct 13, 2026
Merged
Conversation
Step 2 of codebar#3017. The meetings.invites_sent boolean has been dead since 39bbbe5 (2020-12-02) removed its last read and write. The absence is pinned in the meeting spec with a column_exists check. Merge only after the ignored_columns change (codebar#3022) has deployed: old releases name the column in their meeting SELECT list, built from the schema cache at boot, and dropping it while they still serve would fail every meeting query during the Heroku preboot switch.
The respond_to and column_exists checks on invites_sent were one-off verifiers for the removal. Once the drop merges they pin nothing that can drift, so they do not stay in the suite.
mroderick
marked this pull request as ready for review
October 13, 2026 14:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Second half of #3017 — stacks on #3022. The head branch is built on the ignore branch, so this PR shows two commits: #3022's ignore change and the drop below it. Merge #3022 first.
Drops the dead
meetings.invites_sentboolean. Its last read and write were removed in39bbbe52(2020-12-02). The column is now ignored (see #3022), so the drop itself is safe once that change has deployed.Merge and deploy order (load-bearing)
Production runs with Heroku preboot: under merges of the ignore change, old releases build their meeting SELECT list from the schema cache at boot and name every column explicitly. Dropping the column while a release that still names it serves would fail every meeting query on old dynos with
PG::UndefinedColumn.ignored_columnsentry (net change tomeeting.rbacross the pair is zero) and runs the migration in the release phase — the new release never names the column, and all dynos it replaces already carry the ignore.Changes
safety_assured { remove_column :meetings, :invites_sent, :boolean, default: false }in20261013100000_remove_invites_sent_from_meetings.rbself.ignored_columnsentry removed fromMeeting(end state: empty list, no stale entry — avoids recreatingRemove stale ignored_columns entries from Member#3016 debt)schema.rbregenerated (version bumped, column removed)Acceptance
Meeting.ignored_columnsis empty; queries never nameinvites_sent.make test(1730 examples, 0 failures).rubocopclean on all touched files.Review notes
unsubscribeddrop PR). Strong_migrations 2.8.0 prescribes the ignore-then-drop sequence; thesafety_assuredblock is the documented exception, checked against the preboot window.false). The drop loses nothing.