Repository navigation
chore(workshops): ignore the dead sign_up_url column - #3026
Merged
Merged
Conversation
mroderick
added this pull request to stack #3028
October 13, 2026 15:01
mroderick
marked this pull request as ready for review
October 13, 2026 15:03
KimberleyCook
approved these changes
Oct 13, 2026
olleolleolle
approved these changes
Oct 14, 2026
mroderick
force-pushed
the
chore/ignore-sign-up-url-column
branch
from
October 14, 2026 14:51
be29dbc to
b8d6fe1
Compare
mroderick
force-pushed
the
chore/ignore-sign-up-url-column
branch
from
October 14, 2026 15:41
b8d6fe1 to
7efeb18
Compare
Collaborator
Author
|
This has been deployed as part of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3018. Sets up the drop of the dead
workshops.sign_up_urlcolumn, following the two-step approach proven in the invites-sent and unsubscribed stacks.sign_up_urlis a nullable string whose only purpose (an external RSVP link in workshop partials) disappeared when workshop pages moved to invitation-based RSVP inc9391a35(2014-09-09). Nothing has read or written it since; the production snapshot has 3 non-null values of 2603 rows, all set before 2014. This PR adds the column toself.ignored_columnsonWorkshopso Ar stops selecting it and models cannot reach the attribute. The second, stacked PR removes the column.Detail
sign_up_urlappears nowhere outsidedb/schema.rb. The legacy-column spec inspec/models/workshop_spec.rbis transient: the stacked drop PR removes it together with the attribute watcher role it plays (same pattern as meetings).Review notes
chore(meetings): ignorePR one column over.