Skip to content

chore(workshops): ignore the dead sign_up_url column - #3026

Merged
mroderick merged 1 commit into
masterfrom
chore/ignore-sign-up-url-column
Oct 14, 2026
Merged

mroderick merged 1 commit into
masterfrom
chore/ignore-sign-up-url-column

Conversation

@mroderick

Copy link
Copy Markdown
Collaborator

Part of #3018. Sets up the drop of the dead workshops.sign_up_url column, following the two-step approach proven in the invites-sent and unsubscribed stacks.

sign_up_url is a nullable string whose only purpose (an external RSVP link in workshop partials) disappeared when workshop pages moved to invitation-based RSVP in c9391a35 (2014-09-09). Nothing has read or written it since; the production snapshot has 3 non-null values of 2603 rows, all set before 2014. This PR adds the column to self.ignored_columns on Workshop so Ar stops selecting it and models cannot reach the attribute. The second, stacked PR removes the column.

Detail

sign_up_url appears nowhere outside db/schema.rb. The legacy-column spec in spec/models/workshop_spec.rb is transient: the stacked drop PR removes it together with the attribute watcher role it plays (same pattern as meetings).

Review notes

  • Nothing risky: mirrors the merged chore(meetings): ignore PR one column over.
  • Deliberately not done: the column removal itself — that is the stacked PR, which merges after this one deploys and soaks.

@mroderick
mroderick added this pull request to stack #3028 October 13, 2026 15:01
@mroderick
mroderick marked this pull request as ready for review October 13, 2026 15:03
@mroderick
mroderick force-pushed the chore/ignore-sign-up-url-column branch from be29dbc to b8d6fe1 Compare October 14, 2026 14:51
@mroderick
mroderick force-pushed the chore/ignore-sign-up-url-column branch from b8d6fe1 to 7efeb18 Compare October 14, 2026 15:41
@mroderick
mroderick merged commit 7c467fa into master Oct 14, 2026
11 checks passed
@mroderick
mroderick deleted the chore/ignore-sign-up-url-column branch October 14, 2026 15:49
@mroderick

Copy link
Copy Markdown
Collaborator Author

This has been deployed as part of v794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants