Skip to content

chore(workshops): drop the dead sign_up_url column - #3027

Merged
mroderick merged 2 commits into
masterfrom
chore/drop-sign-up-url-column
Oct 14, 2026
Merged

mroderick merged 2 commits into
masterfrom
chore/drop-sign-up-url-column

Conversation

@mroderick

Copy link
Copy Markdown
Collaborator

Part of #3018, stacked on the ignore PR (base = its head branch; when that merges, GitHub retargets this PR to master). Closes #3018 once merged after the ignore PR ships and soaks in production.

Removes sign_up_url from workshops with safety_assured { remove_column }, regenerates db/schema.rb, and drops the transient legacy-column specs.

Detail

Two commits mirroring the merged meetings drop: the migration plus schema regeneration, then the spec removal — each green on its own. The column holds 3 non-null values out of 2603 production rows, all set before 2014, and has had no readers since the invitation-based RSVP switch in c9391a35 (2014-09-09). The migration was regenerated from bin/rails db:migrate rather than edited by hand.

Review notes

  • Merge order gate: ignore PR first, deploy, soak, then this one. The stacked base enforces the ordering in GitHub; the soak window is operational.
  • Deliberately not done: no data migration or backfill — the three stale values go with the column.

@mroderick
mroderick added this pull request to stack #3028 October 13, 2026 15:01
@mroderick
mroderick force-pushed the chore/drop-sign-up-url-column branch 2 times, most recently from 87d7ad5 to 7d16240 Compare October 14, 2026 15:41
Base automatically changed from chore/ignore-sign-up-url-column to master October 14, 2026 15:49
@mroderick
mroderick force-pushed the chore/drop-sign-up-url-column branch from 7d16240 to ac0909f Compare October 14, 2026 15:49
@mroderick
mroderick marked this pull request as ready for review October 14, 2026 16:04
@mroderick
mroderick force-pushed the chore/drop-sign-up-url-column branch from ac0909f to 829b760 Compare October 14, 2026 16:04
@mroderick
mroderick merged commit ec4275f into master Oct 14, 2026
10 checks passed
@mroderick
mroderick deleted the chore/drop-sign-up-url-column branch October 14, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop workshops.sign_up_url

2 participants