Repository navigation
chore(events): ignore the dead coach_description column - #3029
Merged
Merged
Conversation
mroderick
added this pull request to stack #3031
October 13, 2026 15:08
mroderick
marked this pull request as ready for review
October 13, 2026 15:10
KimberleyCook
approved these changes
Oct 13, 2026
olleolleolle
approved these changes
Oct 14, 2026
mroderick
force-pushed
the
chore/ignore-coach-description-column
branch
from
October 14, 2026 15:49
68d06df to
c40e749
Compare
Collaborator
Author
|
This has been deployed as part of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3019. Sets up the drop of the dead
events.coach_descriptioncolumn, following the two-step approach proven in the meetings, workshops and unsubscribed stacks.coach_descriptionis a text column from the early event-invites feature. Its reads were removed inde44fe17(2016-06-14), which replaced the coach-specific text in invitation mailers with the generalevent.description. Nothing reads it today and it is not on any admin form; the production snapshot has 3 non-null values of 260 rows. This PR adds the column toself.ignored_columnsonEventand removes the fabricator line, the only write left in the codebase. The second, stacked PR removes the column.Detail
coach_descriptionappears nowhere else outsidedb/schema.rb. The legacy-column spec inspec/models/event_spec.rbis transient: the stacked drop PR removes it, same pattern as meetings and workshops.Review notes
chore(meetings)andchore(workshops)ignore PRs one column over.