Repository navigation
chore(events): drop the dead coach_description column - #3030
Merged
Merged
Conversation
mroderick
added this pull request to stack #3031
October 13, 2026 15:08
KimberleyCook
approved these changes
Oct 13, 2026
KimberleyCook
left a comment
Contributor
There was a problem hiding this comment.
I'm a big fan of this tidy up 🎉
mroderick
force-pushed
the
chore/drop-coach-description-column
branch
from
October 14, 2026 15:49
830b278 to
638717f
Compare
Base automatically changed from
chore/ignore-coach-description-column
to
master
October 14, 2026 15:53
mroderick
force-pushed
the
chore/drop-coach-description-column
branch
from
October 14, 2026 15:53
638717f to
76d2824
Compare
mroderick
marked this pull request as ready for review
October 14, 2026 16:06
Resolve schema.rb version conflict: keep 2026_10_13_120000 so both column-drop migrations are recorded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3019, stacked on the ignore PR (base = its head branch; when that merges, GitHub retargets this PR to
master). Closes #3019 once merged after the ignore PR ships and soaks in production.Removes
coach_descriptionfromeventswithsafety_assured { remove_column }, regeneratesdb/schema.rb, and drops the transient legacy-column specs.Detail
Two commits mirroring the merged meetings and workshops drops: the migration plus schema regeneration, then the spec removal — each green on its own. The column holds 3 non-null values out of 260 production rows, all unread since the 2016-06-14 invitation mailer switch to
event.description(de44fe17). The migration was regenerated frombin/rails db:migraterather than edited by hand.Review notes