Skip to content

chore(events): drop the dead coach_description column - #3030

Merged
mroderick merged 3 commits into
masterfrom
chore/drop-coach-description-column
Oct 14, 2026
Merged

mroderick merged 3 commits into
masterfrom
chore/drop-coach-description-column

Conversation

@mroderick

Copy link
Copy Markdown
Collaborator

Part of #3019, stacked on the ignore PR (base = its head branch; when that merges, GitHub retargets this PR to master). Closes #3019 once merged after the ignore PR ships and soaks in production.

Removes coach_description from events with safety_assured { remove_column }, regenerates db/schema.rb, and drops the transient legacy-column specs.

Detail

Two commits mirroring the merged meetings and workshops drops: the migration plus schema regeneration, then the spec removal — each green on its own. The column holds 3 non-null values out of 260 production rows, all unread since the 2016-06-14 invitation mailer switch to event.description (de44fe17). The migration was regenerated from bin/rails db:migrate rather than edited by hand.

Review notes

  • Merge order gate: ignore PR first, deploy, soak, then this one. The stacked base enforces the ordering in GitHub; the soak window is operational.
  • Deliberately not done: no data migration or backfill — the three stale values go with the column.

@mroderick
mroderick added this pull request to stack #3031 October 13, 2026 15:08

@KimberleyCook KimberleyCook left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a big fan of this tidy up 🎉

@mroderick
mroderick force-pushed the chore/drop-coach-description-column branch from 830b278 to 638717f Compare October 14, 2026 15:49
Base automatically changed from chore/ignore-coach-description-column to master October 14, 2026 15:53
@mroderick
mroderick force-pushed the chore/drop-coach-description-column branch from 638717f to 76d2824 Compare October 14, 2026 15:53
@mroderick
mroderick marked this pull request as ready for review October 14, 2026 16:06
Resolve schema.rb version conflict: keep 2026_10_13_120000 so both
column-drop migrations are recorded.
@mroderick
mroderick merged commit 67a1cf8 into master Oct 14, 2026
10 checks passed
@mroderick
mroderick deleted the chore/drop-coach-description-column branch October 14, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop events.coach_description

2 participants