[davidmillen50]

this refactor relates to issue 2941

Before: missing organiser_ids raised NoMethodError (nil.reject!) and left roles untouched.
After:

• [] (empty array from form deselect) clears all current organisers (silent, intended)
• nil (absent param) raises ArgumentError ('organiser_ids is required')
• Spec added for absent-param case
• Rubocop clean; controller specs fixed (false positives removed)

[mroderick]

One behaviour change on the update path and two assertion gaps in the new specs - details in the line comments.

The blocker for me is the absent-param handling in WorkshopOrganiserAssigner: nil on update now silently clears all organisers where it previously raised, and nil means chapter fallback on create but full revocation on update. The rest of the extraction looks faithful.

[mroderick]

.not_to raise_error is the only assertion in both new create specs, so they stay green even if the grant never happens: a mistyped service call, or a wrong params key falling back to the chapter default, passes just the same. Could the provided-ids spec also assert the effect?

Suggested change

	end.not_to raise_error
	end.not_to raise_error
	expect(Workshop.unscoped.order(:id).last.organisers).to include(organiser)

(created is assigned on the next line, so the suggestion queries inline; swap the order if you prefer to reuse created.)

The PATCH #update spec below has real value assertions, so this is only about the two create cases.

[davidmillen50]

this should now be resolved

[mroderick]

I have updated the comment above into a suggested change: the added line asserts that the provided organiser id reaches the created workshop, so the spec fails if the params key is dropped and the chapter fallback takes over. Use the "Commit suggestion" button to apply it as-is, or reorder to reuse created if you prefer.

[davidmillen50]

thanks I've applied the suggestion.