Repository navigation
ci(hook): adopt the commit gate in this repo and fail on empty review secrets - #690
Merged
Merged
Conversation
… secrets Signed-off-by: ajianaz <ajianaz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
scripts/hooks/pre-commitandscripts/setup-hooks.sh(core.hooksPath): fmt, clippy when Rust files are staged, thencora hook verifywithcora review --staged --ci --severity majoras fallback.cora-review.yml: the secret guard now errors with the name of each empty secret among CORA_API_KEY, CORA_BASE_URL and CORA_MODEL.Why
Uses the commit gate from #674 in this repository, and makes sure a Cora Review without its secrets can never pass silently.
Testing