Repository navigation
feat(scan): opt-in clone hints, --min-severity and a per-severity summary - #705
Merged
Merged
Conversation
…mary (#683) Signed-off-by: ajianaz <ajianaz@users.noreply.github.com>
ajianaz
force-pushed
the
fix/683-scan-noise
branch
from
October 27, 2026 08:38
22ecb5f to
7fed66a
Compare
ajianaz
added a commit
that referenced
this pull request
Oct 27, 2026
…mary (#705) ## What - `qual-clone` (`.clone()` in Rust, info) is opt-in: `rules_engine.clone_hints: true` turns it on. A default scan of a Rust project no longer lists `Arc::clone`-style sites. - New `cora scan --min-severity <info|minor|major|critical>`: hides lower findings in every output format and in the count. Blocking is unchanged (still `hook.min_severity`). - The scan summary (pretty and JSON output) counts by severity: `found 457 issues (1 critical, 150 minor, 306 info)`. - Docs (`cli-reference`, `configuration`) and CHANGELOG updated. ## Why On a 133-file Rust workspace 306 of 457 findings were `qual-clone` info; the count hid the one critical finding and the `max_findings` cap spent its slots on noise. Closes #683. ## Testing - Unit test: `qual_clone_is_opt_in` (off by default, on with `clone_hints`). - 3 end-to-end tests in tests/scan_noise.rs: no clone sites by default, the JSON summary counts by severity, `--min-severity major` hides minor findings. - fmt, clippy -D warnings and the full suite pass. Signed-off-by: ajianaz <ajianaz@users.noreply.github.com> Co-authored-by: ajianaz <ajianaz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
qual-clone(.clone()in Rust, info) is opt-in:rules_engine.clone_hints: trueturns it on. A default scan of a Rust project no longer listsArc::clone-style sites.cora scan --min-severity <info|minor|major|critical>: hides lower findings in every output format and in the count. Blocking is unchanged (stillhook.min_severity).found 457 issues (1 critical, 150 minor, 306 info).cli-reference,configuration) and CHANGELOG updated.Why
On a 133-file Rust workspace 306 of 457 findings were
qual-cloneinfo; the count hid the one critical finding and themax_findingscap spent its slots on noise. Closes #683.Testing
qual_clone_is_opt_in(off by default, on withclone_hints).--min-severity majorhides minor findings.