Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
check_inenvelope items are parsed and stored; monitors auto-register on first check-in (monitors+monitor_checkins, migration 007 Postgres / timestamped SQLite).checkin_margin, default 60 min) flips tomissedand emits an alert. UTC-only 5-field crontab matcher, no new dependencies.AlertSignal::{Issue, MonitorMissed}— one webhook pipeline for both signal types, existing cooldown respected. Monitor-missed webhook payload:{"type":"monitor_missed",...}.GET /api/0/projects/{slug}/monitors,GET /api/0/projects/{slug}/monitors/{id}/checkins(paginated).list_monitorstool.alert_history.issue_idstoresmonitor:<slug>for monitor alerts.Why
Closes #360. Scheduled jobs (backups, workers, crons) fail silently — error tracking alone never sees a job that never ran. Any Sentry SDK can now report monitor check-ins via the same drop-in DSN swap; staleness alerts flow to the existing Discord/Slack webhooks.
Testing
cargo fmt --all -- --checkclean.cargo clippy --workspace --all-targets -- -D warningsclean.cargo test --workspacegreen: trapfalld unit 92, integration 43, MCP 17 — includes new tests: envelopecheck_inparse, staleness evaluation (fixed timestamps), end-to-end ingest→monitor list→checkins pagination (integration, real envelope POST with sentry-key auth), monitor-missed webhook dispatch + cooldown (offline), retention purge deletes old check-ins / keeps monitors, MCPlist_monitors.--features postgres(clippy clean); live-PG path exercised by the CItest-postgresjob.Limitations (documented in code): timezone field ignored (UTC), interval-type schedules not evaluated, monitor slug length capped at 128.