Fix missing macOS source mount folders - #212
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex reviewNo high-confidence issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
cargo test -p locality-desktop(235 passed, 2 credential-gated tests ignored)swift testinplatform/macos/LocalityFileProvider(22 passed)cargo fmt --allgit diff --checkClippy
cargo clippy -p locality-desktop --all-targets -- -D warningsis currently blocked by pre-existing Rust 1.96 warnings onmain(for examplecrates/locality-core/src/conflict.rs:307and unrelated existing desktop warnings). The changed code compiles and the full desktop test suite passes.