Fix two broken links and the wrong mailing list - #17
Merged
Conversation
The 'Books > Writing Components' menu entry pointed at /writing-components-trail/index.html, which does not exist. Because it lives in site.xml it was broken on every page of the site. Its only child duplicated the working 'Writing Plexus Components' entry directly below it, so the Books group is removed rather than repointed. index.apt linked to ./faq.html, which also does not exist. There is no FAQ to point at, so the sentence goes. Community > Mailing Lists pointed at groups.google.com/g/mojohaus-dev, which belongs to MojoHaus. Plexus has no mailing list; issues are handled per repository on GitHub, so the entry now says so. Verified by building the site and walking every internal link: both targets are gone and nothing new broke. Part of codehaus-plexus/.github#58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of codehaus-plexus/.github#58. The smallest, least arguable piece of the site cleanup — three corrections, seven lines deleted, nothing added.
writing-components-trail/index.html→ 404The Books → Writing Components entry in
site.xmlpoints at a path that doesn't exist. Because it's in the site descriptor, it renders in the left menu of every page on the site, so this is the most-hit broken link we have.Its only child duplicated Writing Plexus Components (
/guides/writing-components/00_index.html), which is directly below it and works. So theBooksgroup is removed rather than repointed — nothing becomes unreachable.faq.html→ 404index.aptcloses with "For answers to common questions about Plexus, see the FAQ." There is no FAQ page and never has been in this repo. Removed the sentence; writing an actual FAQ is a separate question, not a link fix.Mailing list → wrong organisation
Community → Mailing Lists points at
groups.google.com/g/mojohaus-dev. That's MojoHaus — a different org. Anyone following it to ask a Plexus question lands in the wrong place.Plexus has no mailing list of its own, so rather than invent one the entry now points at the GitHub org, where issues actually get handled. (This matches the "where to ask" section of the CONTRIBUTING in codehaus-plexus/.github#60.)
Verification
Built the site and walked every internal link in the output. Both targets are gone and nothing new broke.
That scan also turned up 6 pre-existing broken links inside the archived IoC guides, which I've deliberately left alone here:
The last one goes away with the component-index rewrite. The rest are inside historical content and can be a follow-up if anyone thinks they're worth fixing.