fix(Session): clear session data on destroy in testing environment#10342
Open
gr8man wants to merge 2 commits into
Open
fix(Session): clear session data on destroy in testing environment#10342gr8man wants to merge 2 commits into
gr8man wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the
testingenvironment,Session::destroy()returned early without callingsession_destroy(). While avoiding raw PHP session functions in CLI/testing is expected, doing nothing meant that the mock session data stored in the$_SESSIONsuperglobal remained completely intact. This caused session state to leak between test cases, leading to test pollution.This PR addresses the issue by resetting the
$_SESSIONarray ($_SESSION = []) whendestroy()is called under thetestingenvironment. A unit test has also been added to verify this behavior.Checklist: