Skip to content

refactor: fix phpstan errors in IncomingRequestTest - #10452

Merged
paulbalandan merged 1 commit into
codeigniter4:developfrom
paulbalandan:incoming-request-test
Aug 14, 2026
Merged

refactor: fix phpstan errors in IncomingRequestTest#10452
paulbalandan merged 1 commit into
codeigniter4:developfrom
paulbalandan:incoming-request-test

Conversation

@paulbalandan

Copy link
Copy Markdown
Member

Description
Fixing the cluster of phpstan errors on IncomingRequestTest:

  • Type the property as IncomingRequest, treat one-off uses of Request via local $request
  • Add missing docblocks
  • I deleted a test that asserts PHP's behavior (throwing a TypeError on passing string to array). That is simply ridiculous as a test

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Aug 13, 2026
@paulbalandan
paulbalandan force-pushed the incoming-request-test branch from 30625ce to 74a7ae8 Compare August 13, 2026 12:18
@github-actions github-actions Bot added the stale Pull requests with conflicts label Aug 13, 2026
@github-actions

This comment was marked as outdated.

@paulbalandan
paulbalandan force-pushed the incoming-request-test branch from 74a7ae8 to c63dc2a Compare August 14, 2026 06:51
@paulbalandan paulbalandan removed the stale Pull requests with conflicts label Aug 14, 2026
@paulbalandan
paulbalandan merged commit e3a8f37 into codeigniter4:develop Aug 14, 2026
58 of 59 checks passed
@paulbalandan
paulbalandan deleted the incoming-request-test branch August 14, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants