refactor: add precise parameter types to Router test fixtures - #10464
Open
soccerlover29 wants to merge 2 commits into
Open
refactor: add precise parameter types to Router test fixtures#10464soccerlover29 wants to merge 2 commits into
soccerlover29 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds specific parameter types to 10 methods across the Router test fixtures and helper classes, replacing untyped parameters that PHPStan flagged as "no type specified." All changes are in test-only files. I tested it by running a full-project PHPStan scan and all the relevant tests.
Contributes to #7731 (PHPStan "no type specified" errors).
Checklist: