Repository navigation
Conversation
fess-sso-oidc now sends a nonce with every authorization request and refuses an ID token whose nonce claim is missing or different (codelibs/fess-sso-oidc#9). The 15.10 OIDC page still said that the nonce is not used. - config/sso-oidc: describe the nonce check; PKCE is still not used and iat/nbf are still not checked. - install/upgrade: add the compatibility note to the SSO section (an OP that does not return the nonce cannot be used; a login started before the plugin update fails once). All seven languages. The 15.9 pages are unchanged, as 15.9.0 does not check the nonce.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config/sso-oidc: the 15.10 page said "nonceand PKCE are not used". It now describes the nonce check added in fix: send and verify the OpenID Connect nonce fess-sso-oidc#9. PKCE is still not used, andiatandnbfare still not checked.install/upgrade: adds the compatibility note to the SSO plugin section: an OP that does not return thenonceclaim can no longer be used (there is no setting to relax the check), and a login started before the plugin update fails once.Merge timing
fess-sso-oidc#9 is merged to
mainbut is not in any release yet (the latest tag isfess-sso-oidc-15.9.0). Please merge this only once the 15.10.0 plugin release contains it.