Skip to content

Fix spot bugs issues#4805

Merged
shai-almog merged 3 commits intomasterfrom
fix-spotbugs-issues
Apr 24, 2026
Merged

Fix spot bugs issues#4805
shai-almog merged 3 commits intomasterfrom
fix-spotbugs-issues

Conversation

@shai-almog
Copy link
Copy Markdown
Collaborator

@shai-almog shai-almog commented Apr 24, 2026

No description provided.

@shai-almog
Copy link
Copy Markdown
Collaborator Author

shai-almog commented Apr 24, 2026 •
edited
Loading

Compared 34 screenshots: 34 matched.
✅ JavaScript-port screenshot tests passed.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026 •
edited
Loading

✅ Continuous Quality Report

Test & Coverage

Static Analysis

  • SpotBugs [Report archive]
    • ✅ ByteCodeTranslator: 0 findings (no issues)
    • ✅ android: 0 findings (no issues)
    • ✅ codenameone-maven-plugin: 0 findings (no issues)
    • ✅ core-unittests: 0 findings (no issues)
    • ✅ ios: 0 findings (no issues)
  • ✅ PMD: 0 findings (no issues) [Report archive]
  • ✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

@shai-almog
Copy link
Copy Markdown
Collaborator Author

shai-almog commented Apr 24, 2026 •
edited
Loading

Compared 37 screenshots: 37 matched.

Native Android coverage

  • 📊 Line coverage: 7.92% (4202/53043 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 6.21% (20719/333558), branch 3.02% (973/32174), complexity 3.69% (1134/30766), method 6.50% (932/14344), class 10.68% (203/1900)
    • Lowest covered classes
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
      • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
      • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
      • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/730 lines covered)
      • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
      • kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

  • 📊 Line coverage: 7.92% (4202/53043 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 6.21% (20719/333558), branch 3.02% (973/32174), complexity 3.69% (1134/30766), method 6.50% (932/14344), class 10.68% (203/1900)
    • Lowest covered classes
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
      • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
      • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
      • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/730 lines covered)
      • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
      • kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

Benchmark Results

Detailed Performance Metrics

Metric Duration
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 native encode 758.000 ms
Base64 CN1 encode 214.000 ms
Base64 encode ratio (CN1/native) 0.282x (71.8% faster)
Base64 native decode 595.000 ms
Base64 CN1 decode 291.000 ms
Base64 decode ratio (CN1/native) 0.489x (51.1% faster)
Image encode benchmark status skipped (SIMD unsupported)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026 •
edited
Loading

✅ ByteCodeTranslator Quality Report

Test & Coverage

  • ✅ Tests: 644 total, 0 failed, 2 skipped

Benchmark Results

  • Execution Time: 11297 ms

  • Hotspots (Top 20 sampled methods):

    • 28.91% java.util.ArrayList.indexOf (577 samples)
    • 22.34% java.lang.String.indexOf (446 samples)
    • 17.08% com.codename1.tools.translator.Parser.isMethodUsed (341 samples)
    • 4.11% java.lang.Object.hashCode (82 samples)
    • 2.56% java.lang.System.identityHashCode (51 samples)
    • 1.80% com.codename1.tools.translator.ByteCodeClass.updateAllDependencies (36 samples)
    • 1.55% com.codename1.tools.translator.BytecodeMethod.optimize (31 samples)
    • 1.30% com.codename1.tools.translator.BytecodeMethod.appendMethodSignatureSuffixFromDesc (26 samples)
    • 1.15% com.codename1.tools.translator.ByteCodeClass.calcUsedByNative (23 samples)
    • 0.85% java.lang.StringBuilder.append (17 samples)
    • 0.80% com.codename1.tools.translator.ByteCodeClass.markDependent (16 samples)
    • 0.75% com.codename1.tools.translator.Parser.cullMethods (15 samples)
    • 0.70% com.codename1.tools.translator.bytecodes.CustomInvoke.appendExpression (14 samples)
    • 0.70% com.codename1.tools.translator.BytecodeMethod.appendCMethodPrefix (14 samples)
    • 0.70% com.codename1.tools.translator.Parser.getClassByName (14 samples)
    • 0.70% java.lang.StringCoding.encode (14 samples)
    • 0.55% com.codename1.tools.translator.ByteCodeField.equals (11 samples)
    • 0.55% com.codename1.tools.translator.BytecodeMethod.addToConstantPool (11 samples)
    • 0.55% java.io.FileOutputStream.open0 (11 samples)
    • 0.55% com.codename1.tools.translator.BytecodeMethod.isMethodUsedByNative (11 samples)

  • ⚠️ Coverage report not generated.

Static Analysis

  • ✅ SpotBugs: no findings (report was not generated by the build).
  • ⚠️ PMD report not generated.
  • ⚠️ Checkstyle report not generated.

Generated automatically by the PR CI workflow.

@shai-almog
Copy link
Copy Markdown
Collaborator Author

shai-almog commented Apr 24, 2026 •
edited
Loading

Compared 37 screenshots: 37 matched.
✅ Native iOS screenshot tests passed.

Benchmark Results

  • VM Translation Time: 0 seconds
  • Compilation Time: 174 seconds

Build and Run Timing

Metric Duration
Simulator Boot 65000 ms
Simulator Boot (Run) 1000 ms
App Install 14000 ms
App Launch 6000 ms
Test Execution 201000 ms

Detailed Performance Metrics

Metric Duration
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 native encode 2201.000 ms
Base64 CN1 encode 2598.000 ms
Base64 encode ratio (CN1/native) 1.180x (18.0% slower)
Base64 native decode 1582.000 ms
Base64 CN1 decode 1906.000 ms
Base64 decode ratio (CN1/native) 1.205x (20.5% slower)
Base64 SIMD encode 1496.000 ms
Base64 encode ratio (SIMD/native) 0.680x (32.0% faster)
Base64 encode ratio (SIMD/CN1) 0.576x (42.4% faster)
Base64 SIMD decode 1006.000 ms
Base64 decode ratio (SIMD/native) 0.636x (36.4% faster)
Base64 decode ratio (SIMD/CN1) 0.528x (47.2% faster)
Image encode benchmark iterations 100
Image createMask (SIMD off) 122.000 ms
Image createMask (SIMD on) 29.000 ms
Image createMask ratio (SIMD on/off) 0.238x (76.2% faster)
Image applyMask (SIMD off) 459.000 ms
Image applyMask (SIMD on) 297.000 ms
Image applyMask ratio (SIMD on/off) 0.647x (35.3% faster)
Image modifyAlpha (SIMD off) 351.000 ms
Image modifyAlpha (SIMD on) 3260.000 ms
Image modifyAlpha ratio (SIMD on/off) 9.288x (828.8% slower)
Image modifyAlpha removeColor (SIMD off) 936.000 ms
Image modifyAlpha removeColor (SIMD on) 183.000 ms
Image modifyAlpha removeColor ratio (SIMD on/off) 0.196x (80.4% faster)
Image PNG encode (SIMD off) 2718.000 ms
Image PNG encode (SIMD on) 2600.000 ms
Image PNG encode ratio (SIMD on/off) 0.957x (4.3% faster)
Image JPEG encode 1045.000 ms

@shai-almog shai-almog merged commit 48aca82 into master Apr 24, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shai-almog