Repository navigation
Conversation
Dogfood sets withOTLPReceiver and alloy.extraPorts together. The chart ignores the receiver ports if an operator sets only withOTLPReceiver. Declare the OTLP gRPC and HTTP ports in the chart defaults. They are inert until withOTLPReceiver is true. An operator now sets one value to enable the receiver. This depends on the default prometheus.io/port annotation. Without it, the new ports become scrape targets that share their labels with the Alloy HTTP port target, and the up series for Alloy flaps.
jtslear
force-pushed
the
skarbek/alloy-default-port-annotation
branch
from
October 16, 2026 15:04
443c4f9 to
e704cdd
Compare
jtslear
force-pushed
the
skarbek/alloy-default-otlp-ports
branch
from
October 16, 2026 15:04
c071330 to
8e48a35
Compare
jtslear
changed the base branch from
skarbek/alloy-default-port-annotation
to
main
October 16, 2026 15:08
jtslear
changed the base branch from
main
to
skarbek/alloy-default-port-annotation
October 16, 2026 15:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Declare the OTLP ports (4317, 4318) in the chart defaults for Alloy. They are inert until
alloy.withOTLPReceiveristrue.Review of coder/dogfood#702 (v0.8.0 bump) asked for dogfood settings to become chart defaults. Dogfood sets
withOTLPReceiverandalloy.extraPortstogether. If onlywithOTLPReceiveris set, nothing exposes the ports. That is how the OTLP receiver was lost silently in the first revision of that PR. Source: https://github.com/coder/dogfood/pull/702#pullrequestreview-5547941289withOTLPReceiverstaysfalse. This PR does not open the receiver for existing users.Stacked PR
Base: #90 (
skarbek/alloy-default-port-annotation). Merge #90 first, then retarget this PR tomain.Reason: declared ports become scrape targets. Without the
prometheus.io/portannotation from #90, they share their labels with the Alloy HTTP port target. See test 1.Test
Kind cluster testing results.
This branch with
--set alloy.withOTLPReceiver=true:svc/alloyandsvc/alloy-clusterlist12345,4317,4318.svc/alloy:POST :4318/v1/metricsreturns 200. A TCP connection to:4317succeeds.upstays 1.Notes
compiled/resources.yamlandREADME.mdregenerated withmake buildandmake readme.