Repository navigation
feat(alloy): set default resource requests - #92
Merged
Merged
Conversation
The Alloy container has no resource requests by default. The scheduler reserves nothing for it, and the node evicts it first under memory pressure. Set small CPU and memory requests. Set no limits: usage grows with the number of scrape targets, and a limit could throttle or OOM-kill the collector on large clusters. Operators can override alloy.alloy.resources.
jtslear
force-pushed
the
skarbek/alloy-default-resource-requests
branch
from
October 16, 2026 15:04
9be30ad to
64851f0
Compare
jtslear
marked this pull request as ready for review
October 16, 2026 15:32
dannykopping
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set default resource requests for the Alloy container:
cpu: 50m,memory: 128Mi. No limits.Review of coder/dogfood#702 (v0.8.0 bump) asked for dogfood settings to become chart defaults. Source: https://github.com/coder/dogfood/pull/702#pullrequestreview-5547941289
Dogfood sets requests
200m/1Giand limits200m/2Gi. Those values are sized for the dogfood clusters and are not a safe default. This chart sets no resources for any component, so this PR only adds a floor.Why
Without requests, the scheduler reserves nothing for the collector and the node evicts it first under memory pressure (CRF-2 in that review).
Decision for the reviewer
The values are a judgement call. Both are below real usage on purpose: they only give scheduling weight.
Test
Kind cluster used for testing. Baseline is
main: containerresources: {}.50m/128Mi(this PR)Burstable,resources.requests=50m/128Miup{container="alloy"}= 1Notes
compiled/resources.yamlandREADME.mdregenerated withmake buildandmake readme.