Repository navigation
chore: sync chart version and README with v0.8.0 - #95
Merged
Merged
Conversation
make lint syncs Chart.yaml and the README install command to the latest stable tag. The v0.8.0 tag is newer than the committed files, so check-unstaged fails on main and on every pull request. Commit the output of make chart/version-sync and make readme.
Collaborator
Author
|
When I tagged 0.8.0, I was unaware of this:
|
dannykopping
approved these changes
Oct 16, 2026
Collaborator
Gets me every time 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commit the output of
make chart/version-syncandmake readmefor thev0.8.0tag:coder-observability/Chart.yaml:0.7.5to0.8.0README.md: install command--version 0.7.5to--version 0.8.0Why
make lintsetsChart.yamland the README from the latest stable tag, thencheck-unstagedfails if a file changed. Nothing updates the files when a tag is cut, so main failslintafter every release until a sync commit lands.v0.8.0points at the #88 merge, where the files still said0.7.5. TheLintrun on the #89 merge failed for this reason, and so does every open PR.The published chart is not affected:
scripts/publish.shrunshelm package --version=<tag>.Test
make lintwith helm 3.17.4 and yq 4.42.1 (the CI versions): exit 0, no unstaged changes.Notes
The Makefile already has a TODO to automate this on release. That is out of scope here.