🤖 fix: make TitleBar tooltip CTAs clickable links - #3917
Merged
Conversation
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the call-to-action text in the TitleBar tooltips actually clickable: the version tooltip's "Click for more details" now opens the About dialog, and the gateway/provider route tooltip's "Click to open gateway settings" / "Click to open provider settings" now opens Settings → Providers with the active provider expanded.
Fixes #2330
Background
Both tooltips ended in CTA copy that read like a link but was inert plain text, so clicking the words did nothing (UX papercut). The actions were only reachable by clicking the trigger buttons themselves.
Implementation
<button>elements inside the sharedTooltipContent, invoking the exact same handlers as their triggers (openAboutDialog,openSettings("providers", { expandProvider: activeRouteProvider })). Shared link styling lives in a localTOOLTIP_CTA_CLASSNAMEconstant.TooltipProviderkeeps Radix hoverable-content enabled (pointer can travel from trigger into the tooltip).open/onOpenChange) so the CTA click closes the tooltip before the About dialog / Settings surface opens; otherwise the z-indexed tooltip lingers on top.Validation
make static-checkgreen locally.@media (hover: hover)like all other hover styles.Generated with
mux• Model:anthropic:claude-fable-5• Thinking:xhigh