Skip to content

🤖 fix: make TitleBar tooltip CTAs clickable links - #3917

Merged
ibetitsmike merged 1 commit into
mainfrom
mike/fix-2330-tooltip-cta-links
Aug 21, 2026
Merged

🤖 fix: make TitleBar tooltip CTAs clickable links#3917
ibetitsmike merged 1 commit into
mainfrom
mike/fix-2330-tooltip-cta-links

Conversation

@ibetitsmike

Copy link
Copy Markdown
Contributor

Summary

Makes the call-to-action text in the TitleBar tooltips actually clickable: the version tooltip's "Click for more details" now opens the About dialog, and the gateway/provider route tooltip's "Click to open gateway settings" / "Click to open provider settings" now opens Settings → Providers with the active provider expanded.

Fixes #2330

Background

Both tooltips ended in CTA copy that read like a link but was inert plain text, so clicking the words did nothing (UX papercut). The actions were only reachable by clicking the trigger buttons themselves.

Implementation

  • The two CTAs are now link-styled <button> elements inside the shared TooltipContent, invoking the exact same handlers as their triggers (openAboutDialog, openSettings("providers", { expandProvider: activeRouteProvider })). Shared link styling lives in a local TOOLTIP_CTA_CLASSNAME constant.
  • Clicking inside tooltip content works because the app-level TooltipProvider keeps Radix hoverable-content enabled (pointer can travel from trigger into the tooltip).
  • Both affected tooltips are now controlled (open/onOpenChange) so the CTA click closes the tooltip before the About dialog / Settings surface opens; otherwise the z-indexed tooltip lingers on top.

Validation

  • make static-check green locally.
  • Remote dogfood UAT (browser-mode dev server at this exact head): PASS. Verified pointer travel into both tooltips, CTA clicks open the About dialog / Settings → Providers with the right provider expanded (OpenRouter via real UI flow; Xum Gateway branch incl. Balance/Concurrent rows in logged-out state), no lingering tooltips after any click (DOM-checked), trigger-click regressions unaffected, other TitleBar tooltips unchanged, no overflow at 375px.
  • Known minor UAT observations (accepted, not fixed): tooltip CTA is pointer-only (Radix tooltips close on Tab; the focusable trigger performs the identical action), and the hover color shift is gated by @media (hover: hover) like all other hover styles.

Generated with mux • Model: anthropic:claude-fable-5 • Thinking: xhigh

@ibetitsmike

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: bc04e69e16

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

This comment has been minimized.

@ibetitsmike
ibetitsmike added this pull request to the merge queue Aug 21, 2026
Merged via the queue into main with commit 2cf64a3 Aug 21, 2026
36 of 39 checks passed
@ibetitsmike
ibetitsmike deleted the mike/fix-2330-tooltip-cta-links branch August 21, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link update/install tooltips

1 participant