Repository navigation
release: bot v0.4.0, final results and leaderboard fixes - #112
Merged
Merged
Conversation
#83) The final results post asks unlinked winners to run /link and ends with the closing note, but /leaderboard built the same final message without those options. Pass linking and finalNote the way the cron does; both only apply once the program has ended.
The board image and the contributor card were cached under the full request address, so every new ?v= value (or a login in different letter case) drew the PNG again and fetched the avatars again. Key both on the path and the version the page itself puts in og:image.
* feat: name unlinked qualifiers on the leaderboard When linking is enabled, handleLeaderboardPage calls linkedMembers for qualifying rows (one KV read per login) and passes the map to leaderboardPage. The page renders a line above the board with GitHub profile links for qualifying (or winning, after end) users who haven't linked. No line when linking off, no qualifiers, or all linked. KV lookup failures are logged and the page renders without the line. JSON endpoint unchanged. Closes #55 * fix(page): say 'won but hasn't linked' after program ends Updates the unlinked notice for ended programs to say winners 'won but hasn't linked' instead of 'qualifies but hasn't linked... if you win'. Updates the test accordingly. Addresses feedback from #55 review.
* fix: show full leaderboard logins on phones * fix: keep leaderboard names single-line on phones
* fix: show ended program message on no-card pages * fix: use neutral wording on ended no-card pages
Build the contributor page's GitHub search from program.repos, the same way searchMergedPrs does, instead of searching the whole organization. Closes #101
A merged PR whose program label is added after the merge used to keep a shoutout with no count, and the board only refreshed when the cache ran out. Handle the labeled event for an already-merged PR: count it the same way a merge does, refresh the board, and edit the stored shoutout so it reads like it had the label at the merge, including the qualify line. A shoutout that already has the count, an open PR, or any other label changes nothing. Closes #59 Co-authored-by: harshit-exe-dev <harshit-exe-dev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets the bot ready for the end of the October program: the final results post, the leaderboard page and
/leaderboardall read right once it's over, and/meworks again after a GitHub rename.Final results
/leaderboardstill asks unlinked winners to run/linkand shows the closing note (thanks @sank8-2, fix: show the /link ask and closing note in /leaderboard after the end #83)Leaderboard page
og:type(thanks @srujankaleru2007, fix: add Open Graph type to leaderboard #104)?v=no longer forces a fresh render (fix: key the share image cache on the server's version #89)Shoutouts, releases and commands
/mefinds a member's account again after they rename it on GitHub (thanks @Pratham2511, fix: recover renamed GitHub accounts in /me #91)Naming unlinked qualifiers is a new feature, so this is a minor release (v0.4.0).
Come hang out with us on Discord: https://discord.gg/mpGdJyjaRQ