Skip to content

feat(templates): add podcast Listen On template - #267

Merged
anurag629 merged 4 commits into
codercops:devfrom
srujankaleru2007:feat/issue-243-podcast-listen-on
Oct 26, 2026
Merged

anurag629 merged 4 commits into
codercops:devfrom
srujankaleru2007:feat/issue-243-podcast-listen-on

Conversation

@srujankaleru2007

Copy link
Copy Markdown
Contributor

Description

Adds the podcast-listen-on template for podcast episode announcements, including show and episode metadata, an optional tagline, and up to three listening-platform pills. Empty optional values are hidden, platform labels are truncated without shrinking their pills, and pill text uses a contrasting color.

Closes #243

How I Tested This

  • npm run check — passed with 0 errors (10 existing hints).
  • npm run test -- --maxWorkers=1 --testTimeout=30000 — passed: 59 files, 1226 tests.
  • npm run dev — opened the Podcast editor, selected Listen On, and checked the default and empty/long-field behavior.
  • git diff --check upstream/dev...HEAD — passed.
  • The default parallel npm run test run exceeded the 5-second timeout in six existing render-heavy tests; the full serial run above passed.

AI Assistance

Copilot assisted with repository analysis, implementation, and test verification. I reviewed the changes and ran the checks listed above.

Type of Change

  • Bug fix
  • New template
  • New feature
  • Documentation
  • Tests
  • Refactoring
  • Performance improvement
  • Other (describe below)

Screenshots

Listen On template preview

Checklist

  • This PR targets dev
  • I was assigned the linked issue
  • npm run check passes
  • npm run test passes
  • For a bug fix: the new test fails without my change
  • Tested locally with npm run dev
  • Screenshots included for visual changes
  • New templates follow the Template Guidelines

srujankaleru2007 and others added 3 commits October 26, 2026 19:39
Closes codercops#243

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve Listen On registration alongside recent podcast templates.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@anurag629 anurag629 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srujankaleru2007, this is close. Check, all 1293 tests and the build pass on top of dev, and the default, long title and platform names, and blank episode, tagline and platform renders look right.

Two things before I merge:

  1. On a light background the accent text gets hard to read. With bgColor=ffffff and accentColor=fde047, "Out now" and the dot between the show name and the episode are pale yellow on white. A darker accent for text on light backgrounds, like the other templates use (isLightColor(bgColor) ? mixColors(accentColor, '#000000', 0.45) : accentColor), fixes it. The pills are fine since they use contrastText(). A test for it would be good.
  2. screenshots/podcast-listen-on.png got committed into the repo. Screenshots go in the PR description, so please drop that file from the PR.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@srujankaleru2007

Copy link
Copy Markdown
Contributor Author

Hi, I’ve completed the requested changes in commit 45f4104:

  • Accent text for “Out now” and the show/episode separator now darkens on light backgrounds, with a regression test for the white background and yellow accent case. Pill text continues to use contrastText().
  • Removed screenshots/podcast-listen-on.png from the branch.

Focused tests, npm run check, and npm run build pass.

@anurag629 anurag629 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srujankaleru2007, that does it. "Out now" and the dot read well on a light background now, the screenshot is out of the repo, and check, all 1294 tests and the build pass on top of dev.

@anurag629 anurag629 added the hacktoberfest-accepted PR counts for Hacktoberfest label Oct 26, 2026
@anurag629
anurag629 merged commit 6a7b922 into codercops:dev Oct 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted PR counts for Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the Listen On podcast template (podcast-listen-on)

2 participants