Repository navigation
feat(templates): add Welcome newsletter template (#247) - #271
Merged
Merged
Conversation
Add the Welcome newsletter template (`newsletter-welcome`) with expectations and sign-off. Closes codercops#247
anurag629
approved these changes
Oct 26, 2026
anurag629
left a comment
Member
There was a problem hiding this comment.
Thanks @bhushan4work, this works. Check, all 1302 tests and the build pass on top of dev, and the renders look right: default, a white background with a pale accent, a long name with long items, and blank items that renumber with the sign-off hidden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the Welcome newsletter template (
newsletter-welcome) with expectations and sign-off.Closes #247
Description
Adds a newsletter welcome template with a customizable label, newsletter name, up to three numbered expectations, and an optional sign-off. Empty items are skipped and remaining items are renumbered consecutively. Long text is truncated safely, and color-aware styling maintains readability on light and dark backgrounds.
The template is exported and registered in the newsletter category, with focused tests covering registration, rendering, item numbering, empty fields, truncation, and contrast.
How I Tested This
npx vitest run tests/templates/welcome.test.tspassed (13 tests).npx vitest run tests/templates/registry.test.tspassed (8 tests).npx vitest run tests/templates/render.test.ts -t "newsletter-welcome"passed.npm run checkpassed (0 errors, 0 warnings).npm run buildpassed.AI Assistance
none
Type of Change
Screenshots
Checklist
devnpm run checkpassesnpm run testpassesnpm run dev