Repository navigation
feat: add GitHub Maintainers Wanted template - #298
Conversation
Signed-off-by: Anurag Yadav <anuragyadav2787@gmail.com>
|
Hi @anurag629 could you please review and let me know if any changes required |
anurag629
left a comment
There was a problem hiding this comment.
Thanks @anurag2787, looks good overall. Check (0 errors), all 1515 tests and the build pass on top of dev, and the renders hold up: the defaults, a white background with dark text, a yellow accent on white (the label and icons darken and stay readable), a long name, pitch and help line (they shrink and truncate), and blank help lines or an empty pitch or site name all go away cleanly. Two things:
- Please drop the
package-lock.jsonchange. It only removeslibclines, which is what a different npm version does, and it has nothing to do with the template. - When both
starsandopenIssuesare blank, the stats row goes away and takes its 20px margins with it, so the first help line ends up almost touching the pitch. Giving the help list its own top margin when the stats row is hidden fixes it.
Signed-off-by: Anurag Yadav <anuragyadav2787@gmail.com>
|
Hi @anurag629 i have updated PR could you please re review and let me know if any other changes required |
anurag629
left a comment
There was a problem hiding this comment.
Thanks @anurag2787, both fixed. Check (0 errors), all 1516 tests and the build pass on top of dev, the lockfile is out of the diff, and with the stats blank the help list now sits 24px under the pitch (or the name when the pitch is blank too). The default card renders exactly as before.
Description
Added the github-maintainers-wanted template to help open source projects find new maintainers
Closes #297
How I Tested This
Ran npm run check and npm run test
AI Assistance
ChatGPT was used to help with the implementation and tests
Type of Change
Screenshots
Checklist
devnpm run checkpassesnpm run testpassesnpm run dev