Repository navigation
fix(templates): give Sponsors Goal and Milestone number fields a slider range - #305
Merged
anurag629 merged 1 commit intoOct 28, 2026
Merged
Conversation
anurag629
approved these changes
Oct 28, 2026
anurag629
left a comment
Member
There was a problem hiding this comment.
Thanks @prakashNalla, small and right. Check (0 errors), all 1539 tests and the build pass on top of dev. The editor passes min/max straight to SliderControl, so Raised and Goal now go to 10,000 and Closed and Total to 1,000 with every default inside its range, and the new registry test will catch the next template that ships a default outside its slider.
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Raised and Goal on Sponsors Goal and Closed and Total on Milestone had no
min/max, so the editor'sSliderControlgave them its0to100default and both Sponsors Goal defaults (420 and 1000) started out of range. They now havemin: 0withmax: 10000for Raised and Goal andmax: 1000for Closed and Total.I also added a registry test that every number field's default sits inside its slider range, using the same
0/100fallback asSliderControl, so a new template can't ship with the same problem. These were the only 4 of the 17 number fields without amax.Closes #302
How I Tested This
On
npm run dev,/create/github?template=github-sponsors-goal, Customize tab:max=10000, and one left arrow on Goal sets it to 999The new test in
tests/templates/registry.test.tsfails without the template changes (github-sponsors-goal.raised: expected 420 to be less than or equal to 100) and passes with them.npm run check: 0 errors, 0 warnings.npm run test: 77 files, 1539 tests pass.agenda.test.tstimed out once at 5000ms ("renders valid SVG and PNG for 2, 3, and 4 sessions") in the full run and passes on its own.npm run build: passes.AI Assistance
Claude helped me w/ understand the issue
Type of Change
Screenshots
N/A, the rendered images don't change. The fix is the slider range in the editor, and the before and after values are above.
Checklist
devnpm run checkpassesnpm run testpassesnpm run dev