Repository navigation
fix(editor): include og:site_name in copied meta tags - #307
Merged
Merged
Conversation
anurag629
approved these changes
Oct 28, 2026
anurag629
left a comment
Member
There was a problem hiding this comment.
Thanks @prakashNalla, one line and a test, exactly right. Check (0 errors), all 1541 tests and the build pass on top of dev, and Copy Meta Tags now gets siteName the same way it gets the title and description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Copy Meta Tags left out
og:site_name.generateMetaTags()already writes it when it gets asiteName, butExportBaronly passed the title, description and image URL. It now passessiteNamefrom the editor params the same way astitleanddescription, so it's there when Site Name is set and left out when it's empty.Closes #306
How I Tested This
On
npm run dev,/create/saas?template=saas-maintenancewith the default Site Name ("Acme Cloud"), Copy Meta Tags now copies<meta property="og:site_name" content="Acme Cloud" />next toog:title.Added
tests/editor/export-bar.test.ts, which rendersExportBarand checks what it passes togenerateMetaTags():siteNameis there when Site Name is set and undefined when it's empty. The first test fails without the change and passes with it.npm run check: 0 errors, 0 warnings.npm run test: 78 files, 1541 tests pass.agenda.test.tstimed out once at 5000ms ("renders valid SVG and PNG for 2, 3, and 4 sessions") in the full run and passes on its own.npm run build: passes.AI Assistance
Claude helped me w/ understand the issue
Type of Change
Screenshots
N/A, nothing changes visually. The fix is in the copied text, which is shown above.
Checklist
devnpm run checkpassesnpm run testpassesnpm run dev