Repository navigation
fix: round fractional height values in resolveDimensions - #316
Merged
Merged
Conversation
Signed-off-by: Anurag Yadav <anuragyadav2787@gmail.com>
Contributor
Author
|
Hi @anurag629 could you please review and let me know if any changes required |
anurag629
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed resolveDimensions to round height values to the nearest integer, consistent with width handling
Closes #313
How I Tested This
Ran npm run check and npm run test
AI Assistance
ChatGPT was used to help with the implementation and tests
Type of Change
Checklist
devnpm run checkpassesnpm run testpassesnpm run dev