Skip to content

fix: prevent assert string evaluation in REST controller on PHP 7 #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imantsk wants to merge 1 commit into
base: core-beta
Choose a base branch
from
+1 −1
Open

fix: prevent assert string evaluation in REST controller on PHP 7 #412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/php/REST_API/REST_Controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ abstract class REST_Controller {
*/
public function __construct() {
assert( static::VERSION > 0, get_class( $this ) . '::VERSION must be set' );
assert( static::BASE_ROUTE, get_class( $this ) . '::BASE_ROUTE must be set' );
assert( static::BASE_ROUTE !== '', get_class( $this ) . '::BASE_ROUTE must be set' );

$this->namespace = REST_API_NAMESPACE . static::VERSION;
add_action( 'rest_api_init', [ $this, 'register_routes' ] );
Expand Down
Loading