Outline external link cards on title focus#2408
Merged
tf merged 1 commit intocodevise:masterfrom Apr 27, 2026
Merged
Conversation
Card-link cards use the title as the link. The native focus ring around the title text doesn't communicate that the whole card is the click target, and in variants without inner padding it gets clipped by the card's border-radius overflow. Move the ring to the card itself so keyboard focus matches the activation surface. Expose the project's focus-outline value as a CSS custom property so other components can opt into a custom focus surface while inheriting the same color and the existing disable-on-mouse behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Card-link cards use the title as the link. The native focus ring around the title text doesn't communicate that the whole card is the click target, and in variants without inner padding it gets clipped by the card's border-radius overflow. Move the ring to the card itself so keyboard focus matches the activation surface.
Expose the project's focus-outline value as a CSS custom property so other components can opt into a custom focus surface while inheriting the same color and the existing disable-on-mouse behavior.