Editor inline comments#2409
Merged
tf merged 13 commits intocodevise:masterfrom Apr 28, 2026
Merged
Conversation
Extend the inline editing text editor to surface unresolved comment threads: highlight the commented ranges inline and position a badge next to each range. This makes ongoing discussions visible while editing without leaving the flow. Rename CommentBadge to ThreadsBadge and extract a presentational Badge component so badges can be rendered with an explicit counter for contexts that do not derive their count from thread lookup. REDMINE-21261
Clicking a thread badge next to a commented text range now selects the thread in the editor. This sets up navigation to a per-thread comments view in the editor sidebar.
When a comment thread badge is selected in the preview, the editor sidebar now opens a dedicated view showing just that thread. This avoids scrolling through all threads of a content element when responding to a specific conversation inline. Adds a Thread export from the review module and a new backbone view wired to /scrolled/comment_threads/:id.
Let reviewers resolve a comment thread directly from the per-thread sidebar view. After resolving, reset the selection so the sidebar leaves the thread route.
Reduce visual noise by showing only a dot for badges that are not in the currently edited block. Badges in the block containing the text cursor render full-sized, and the badge for the selected thread stands out in its active style.
Make it visible which range belongs to the thread currently open in the editor sidebar by applying the selected highlight style to its decoration, matching the behavior of ClickableHighlight in the preview commenting EditableText.
Add an 'Add comment' button to the hovering toolbar in inline editing mode. Clicking it selects the current text range as a pending new thread in editor state and highlights the range while the editor sidebar hosts the new thread form.
Handle newThread selections in the editor: stash the pending subject and range on the entry, navigate to a dedicated sidebar route, and show a new backbone view that renders the review NewThreadForm for the range selected in the preview.
Report the current range-ref position for every tracked comment thread alongside the EditableText value on each debounced save, so downstream can persist any range shifts caused by text edits.
tf
force-pushed
the
editor-inline-comments
branch
from
700db10 to
8045fee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REDMINE-21261