Repository navigation
Searchable, fast picker for linking logins and 2FA codes - #105
Open
danielehrhardt wants to merge 1 commit into
Open
danielehrhardt wants to merge 1 commit into
danielehrhardt wants to merge 1 commit into
Conversation
The Linked login select rendered every vault login at once, which made the Edit 2FA dialog lag with large vaults and offered no way to search. Replace it (and the 2FA select in the login dialog) with a compact search picker that shows matching-domain suggestions first and renders at most 50 rows.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linked login field in the Edit 2FA dialog was a plain select that rendered every vault login at once (~2,400 rows). It lagged on open, stretched across the whole window and had no search.
Changes
LinkPicker(components/vault/link-picker.tsx): popover combobox sized to its field, search box focused on open, matches name, username and domain (multi-word), logins on the same domain as the 2FA issuer shown first as Suggested, at most 50 rows rendered with a "N more, keep typing" hint, site favicons per row.Favicongets anxssize for list rows.Verified
Sandbox core with 2,400 logins: picker opens with the search focused, 51 rows rendered instead of 2,400, wheel scroll works inside the dialog, search narrows instantly, selecting and saving links the login.
pnpm typecheckpasses.