feat!: move publicly exposed constants to a new public constants file#2636
Open
MortGron wants to merge 2 commits into
Open
feat!: move publicly exposed constants to a new public constants file#2636MortGron wants to merge 2 commits into
MortGron wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2636 +/- ##
==========================================
- Coverage 93.08% 93.07% -0.01%
==========================================
Files 486 487 +1
Lines 49671 49674 +3
==========================================
+ Hits 46235 46236 +1
- Misses 3436 3438 +2
🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates several constants and the Omitted sentinel from the internal _constants.py module to a new public constants.py module, updating imports across the SDK and its auto-generated sync layers. The review feedback identifies an oversight where some constants in files.py were still being imported from the private module and suggests clarifying the visibility of _RUNNING_IN_BROWSER to ensure its naming aligns with its intended public or private use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some constants that were part of the public interface were included in a private constatns file. These constants have been move to a new public constatns file.
Alternatively, all constants could be moved to this new file, and private constants can have a leading underscore, or what is public can be set with _all_.
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.