feat(Data Modeling, Time Series): Extend Data Modeling with Time Series /retrieve + /list (DM-3843)#2672
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the DataModelingTimeSeriesAPI (and its sync counterpart) to support retrieving and listing time series nodes. It also refactors the source resolution logic from the files API into a shared utility module _data_modeling.py. Feedback on the changes suggests avoiding bare dict in type hints for the sort parameter in both async and sync list methods to adhere to strong typing principles, and removing a redundant top-level import of AsyncCogniteClient in the sync time series API file to prevent potential circular imports.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2672 +/- ##
==========================================
+ Coverage 93.62% 93.63% +0.01%
==========================================
Files 493 498 +5
Lines 50100 50245 +145
==========================================
+ Hits 46905 47046 +141
- Misses 3195 3199 +4
🚀 New features to boost your workflow:
|
|
🦄 |
Makes it much easier to work with time series created through data modeling by adding a separate API class for it (following in the footsteps of "DM Files" #2665.