Skip to content

feat: allow animated stroke and text background#771

Open
hcopp wants to merge 3 commits into
masterfrom
hunter/mobile-charts-animated-colors
Open

feat: allow animated stroke and text background#771
hcopp wants to merge 3 commits into
masterfrom
hunter/mobile-charts-animated-colors

Conversation

@hcopp

@hcopp hcopp commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

What changed? Why?

This PR adds support for animating stroke and text background, properties that we passed on to RN skia.

AnimatedProps support either a direct value (such as string) or a shared value, which can be animated in the UI thread.

This unlocks lines that change colors (such as based on user scrubbing).

UI changes

No visual changes expected, still working as anticipated.

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@hcopp hcopp self-assigned this Jun 24, 2026
cb-ekuersch
cb-ekuersch previously approved these changes Jun 24, 2026
return interpolateColors(colorProgress.value, [0, 1], [previousFill, fill]);
}
return interpolateColors(colorProgress.value, [0, 1], [previousFill, fill]);
return fill;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All still works as expected here

Simulator.Screen.Recording.-.iPhone.17.-.2026-06-24.at.17.18.46.mov

@hcopp hcopp requested a review from cb-ekuersch June 24, 2026 21:21
@github-actions

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants