chore: drop uv.lock, committed to #17 by accident - #19
Merged
Conversation
3,162 lines, 93% of that pull request, and none of it belongs here. The project builds with setup.py and pyproject.toml and does not use uv anywhere; that file only recorded the throwaway environment I ran the tests in (pytest, requests, pydantic pulled in with 'uv run --with'). It slipped in on the second commit: re-running the tests to check the CodeQL fix regenerated the file, and 'git add -A' swept it up. Added to .gitignore so it cannot happen again. The real change in #17 was 243 lines across five files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My mistake in #17.
uv.lockis 3,162 lines, 93% of that PR, and none of itbelongs in this repo.
The project builds with
setup.pyandpyproject.tomland does not reference uvanywhere. That file only recorded the throwaway environment I ran the tests in:
pytest, requests and pydantic pulled in with
uv run --with. It is my localtooling, not this project's dependency graph, and anyone reading it would
reasonably assume otherwise.
How it got in. I deleted it before the first commit. Re-running the tests to
verify the CodeQL fix regenerated it, and the
git add -Aon the second commitswept it up. Now in
.gitignoreso it cannot recur.The real change in #17 was 243 lines across five files:
dexpaprika_sdk/client.pytests/test_api_key.pyREADME.mdCHANGELOG.mddexpaprika_sdk/__init__.pyI checked the other three SDK PRs for the same problem: Go, TypeScript and PHP
are all clean, only intended files.