Skip to content

chore(deps): update @sveltejs/kit to v3 and @sveltejs/adapter-auto to v8 - #491

Open
farnabaz wants to merge 1 commit into
mainfrom
chore/sveltekit-3
Open

farnabaz wants to merge 1 commit into
mainfrom
chore/sveltekit-3

Conversation

@farnabaz

@farnabaz farnabaz commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

combines #474 and #475. the two bumps depend on each other (adapter-auto 7 peers on kit ^2, adapter-auto 8 peers on kit ^3), so each one alone fails the sveltekit preview.

kit 3 also broke the sveltekit example, so this migrates it:

  • svelte.config.js is no longer read, so the adapter, experimental.async and vitePreprocess move into sveltekit({...}) in vite.config.ts
  • tsconfig.json now has to extend $app/tsconfig
  • $lib is gone, replaced by #lib subpath imports in the example's package.json. TS doesn't add extensions through subpath imports, so the .ts import needs an explicit extension

the svelte rendering docs also get a note that sveltekit 3 users set experimental.async through the vite plugin instead of svelte.config.js.

supersedes #474 and #475.

Summary by CodeRabbit

  • Documentation

    • Added guidance for enabling Svelte’s experimental async feature in SvelteKit 3.
  • Updates

    • Updated the SvelteKit example configuration and import aliases for compatibility with SvelteKit 3.
    • Updated the example’s TypeScript configuration and SvelteKit package versions.

Moves the SvelteKit example's config from svelte.config.js into the
sveltekit() vite plugin, extends $app/tsconfig and replaces $lib with
#lib subpath imports, as required by kit 3.
@coldtea-pr-lens

Copy link
Copy Markdown

Note

The title starts with chore(deps):, so PR Lens left this pull request undrawn. Comment @pr-lens draw to draw it

github.comment.notice: false in .github/pr-lens.yml turns this note off

@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
comark Ready Ready Preview Oct 16, 2026 2:01pm UTC
comark-binding Ready Ready Preview Oct 16, 2026 2:01pm UTC
comark-json-render Ready Ready Preview Oct 16, 2026 2:01pm UTC
comark-nextjs Ready Ready Preview Oct 16, 2026 2:01pm UTC
comark-nuxt Ready Ready Preview Oct 16, 2026 2:01pm UTC
comark-svelte Ready Ready Preview Oct 16, 2026 2:01pm UTC
comark-sveltekit Ready Ready Preview Oct 16, 2026 2:01pm UTC
comark-twoslash Ready Ready Preview Oct 16, 2026 2:01pm UTC
comark-vue Ready Ready Preview Oct 16, 2026 2:01pm UTC

@github-actions

Copy link
Copy Markdown
Contributor

Documentation previews

📚 Preview all documentation changes (follows new pushes)

Pinned to the current head: cbd678a

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 00ad42e9-c57e-451e-b222-f55b0206a2bb
📥 Commits

Reviewing files that changed from the base of the PR and between 824e49a and cbd678a.

⛔ Files ignored due to path filters: 1
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing: 9
  • docs/content/3.rendering/6.svelte.md
  • examples/1.frameworks/sveltekit/package.json
  • examples/1.frameworks/sveltekit/src/routes/+page.server.ts
  • examples/1.frameworks/sveltekit/src/routes/stable/+page.server.ts
  • examples/1.frameworks/sveltekit/src/routes/stable/+page.svelte
  • examples/1.frameworks/sveltekit/svelte.config.js
  • examples/1.frameworks/sveltekit/tsconfig.json
  • examples/1.frameworks/sveltekit/vite.config.ts
  • pnpm-workspace.yaml
💤 Files with no reviewable changes: 1
  • examples/1.frameworks/sveltekit/svelte.config.js

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The SvelteKit example updates its dependency versions, Vite and TypeScript configuration, and local import aliases. The Svelte rendering guide adds a SvelteKit 3 example for enabling Svelte’s experimental async compiler option.

Changes: SvelteKit 3 example migration

Layer / File(s) Summary
SvelteKit 3 configuration
pnpm-workspace.yaml, examples/1.frameworks/sveltekit/vite.config.ts, examples/1.frameworks/sveltekit/svelte.config.js, examples/1.frameworks/sveltekit/tsconfig.json, docs/content/3.rendering/6.svelte.md
The workspace updates the SvelteKit and adapter-auto versions. The example moves its async compiler option, preprocessing, and adapter configuration to vite.config.ts, removes svelte.config.js, and updates its TypeScript settings. The guide adds a matching configuration example.
Package alias imports
examples/1.frameworks/sveltekit/package.json, examples/1.frameworks/sveltekit/src/routes/+page.server.ts, examples/1.frameworks/sveltekit/src/routes/stable/+page.server.ts, examples/1.frameworks/sveltekit/src/routes/stable/+page.svelte
The example defines #lib aliases and updates the content and component imports to use them.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: atinux

Merge Risk: ⚪ Minimal · up to cbd67

The SvelteKit example follows the Kit 3 configuration and import conventions, and its Kit and adapter versions are compatible. No concrete behavior or installation failure was identified, so the change is mergeable after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: updating @sveltejs/kit to v3 and @sveltejs/adapter-auto to v8. It matches the dependency updates and the related SvelteKit 3 migration.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files. (5 skipped: 5 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codspeed

codspeed Bot commented Oct 16, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ 1 benchmark spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

✅ 41 untouched benchmarks


Comparing chore/sveltekit-3 (cbd678a) with main (824e49a)

Open in CodSpeed

@pkg-pr-new

pkg-pr-new Bot commented Oct 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

comark

npm i https://pkg.pr.new/comark@491

@comark/angular

npm i https://pkg.pr.new/@comark/angular@491

@comark/ansi

npm i https://pkg.pr.new/@comark/ansi@491

@comark/html

npm i https://pkg.pr.new/@comark/html@491

@comark/nuxt

npm i https://pkg.pr.new/@comark/nuxt@491

@comark/react

npm i https://pkg.pr.new/@comark/react@491

@comark/svelte

npm i https://pkg.pr.new/@comark/svelte@491

@comark/vue

npm i https://pkg.pr.new/@comark/vue@491

commit: cbd678a

This branch was successfully deployed

8 active deployments
Preview – comark-nuxt — cbd678a1 Deployed Oct 16, 2026 by vercel[bot]
Preview – comark-sveltekit — cbd678a1 Deployed Oct 16, 2026 by vercel[bot]
Preview – comark-vue — cbd678a1 Deployed Oct 16, 2026 by vercel[bot]
Preview – comark-twoslash — cbd678a1 Deployed Oct 16, 2026 by vercel[bot]
Preview – comark-svelte — cbd678a1 Deployed Oct 16, 2026 by vercel[bot]
Preview – comark-json-render — cbd678a1 Deployed Oct 16, 2026 by vercel[bot]
Preview – comark-nextjs — cbd678a1 Deployed Oct 16, 2026 by vercel[bot]
Preview – comark-binding — cbd678a1 Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant