Skip to content

VM's: report a finished VM as done, not aborted #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MickLesk merged 2 commits into from
Sep 23, 2026
Merged

VM's: report a finished VM as done, not aborted #65

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4abd79
Report a finished VM as done, not aborted
MickLesk Sep 23, 2026
aec75b7
Trim comments
MickLesk Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pve/vm-core.func
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,10 +719,11 @@ cleanup() {
if declare -f post_update_to_api >/dev/null 2>&1; then
if [[ $exit_code -ne 0 ]]; then
post_update_to_api "failed" "$exit_code"
elif [[ -n "${VMID:-}" ]] && qm config "$VMID" &>/dev/null; then
# Clean exit with the VM in place: a script that never said so itself.
post_update_to_api "done" "none"
else
# Exited cleanly but description()/success was never called: the user
# backed out of a dialog. Report as aborted - NOT "failed 1" (which
# produced meaningless 'General error' records with no error text).
# Clean exit, no VM: the user backed out of a dialog.
post_update_to_api "aborted" "0"
fi
fi
Expand Down
Loading